Skip to content

Revert "Bugfix: Yield after every execution of 'loop' if a loop delay of 0 is specified" #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Revert "Bugfix: Yield after every execution of 'loop' if a loop delay of 0 is specified" #45

merged 1 commit into from
Nov 5, 2021

Conversation

aentinger
Copy link
Contributor

Reverts #38

We are using a preemptive RTOS therefore each task is automatically interrupted and a context switch is performed after time_slice (in our case with a duration of 10 ms) is up.

@aentinger aentinger self-assigned this Nov 5, 2021
@aentinger aentinger merged commit 543e96a into main Nov 5, 2021
@aentinger aentinger deleted the revert-38-yield-if-no-delay branch November 5, 2021 06:17
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Memory usage change @ 2ca530d

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 💚 -64 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Threading/Demo_Shared_Counter
flash		 % examples/Threading/Demo_Shared_Counter
RAM for global variables		 % examples/Threading/Demo_Source_Sink_Counter
flash		 % examples/Threading/Demo_Source_Sink_Counter
RAM for global variables		 % examples/Threading/Demo_Source_Sink_LED
flash		 % examples/Threading/Demo_Source_Sink_LED
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_SPI
flash		 % examples/Threadsafe_IO/Threadsafe_SPI
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_SPI_BusIO
flash		 % examples/Threadsafe_IO/Threadsafe_SPI_BusIO
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Serial_GlobalPrefixSuffix
flash		 % examples/Threadsafe_IO/Threadsafe_Serial_GlobalPrefixSuffix
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Serial_ProtocolWrapping
flash		 % examples/Threadsafe_IO/Threadsafe_Serial_ProtocolWrapping
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Serial_Reader
flash		 % examples/Threadsafe_IO/Threadsafe_Serial_Reader
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Serial_Writer
flash		 % examples/Threadsafe_IO/Threadsafe_Serial_Writer
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Wire
flash		 % examples/Threadsafe_IO/Threadsafe_Wire
RAM for global variables		 % examples/Threadsafe_IO/Threadsafe_Wire_BusIO
flash		 % examples/Threadsafe_IO/Threadsafe_Wire_BusIO
RAM for global variables		 %
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 -64 -0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Threading/Demo_Shared_Counter<br>flash,%,examples/Threading/Demo_Shared_Counter<br>RAM for global variables,%,examples/Threading/Demo_Source_Sink_Counter<br>flash,%,examples/Threading/Demo_Source_Sink_Counter<br>RAM for global variables,%,examples/Threading/Demo_Source_Sink_LED<br>flash,%,examples/Threading/Demo_Source_Sink_LED<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_SPI<br>flash,%,examples/Threadsafe_IO/Threadsafe_SPI<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_SPI_BusIO<br>flash,%,examples/Threadsafe_IO/Threadsafe_SPI_BusIO<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Serial_GlobalPrefixSuffix<br>flash,%,examples/Threadsafe_IO/Threadsafe_Serial_GlobalPrefixSuffix<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Serial_ProtocolWrapping<br>flash,%,examples/Threadsafe_IO/Threadsafe_Serial_ProtocolWrapping<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Serial_Reader<br>flash,%,examples/Threadsafe_IO/Threadsafe_Serial_Reader<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Serial_Writer<br>flash,%,examples/Threadsafe_IO/Threadsafe_Serial_Writer<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Wire<br>flash,%,examples/Threadsafe_IO/Threadsafe_Wire<br>RAM for global variables,%,examples/Threadsafe_IO/Threadsafe_Wire_BusIO<br>flash,%,examples/Threadsafe_IO/Threadsafe_Wire_BusIO<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,-64,-0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

aentinger added a commit that referenced this pull request Nov 5, 2021
@aentinger
Remove superfluous rtos::ThisThread::yield().
46d08b2 
See #45 for more information.
aentinger added a commit that referenced this pull request Nov 5, 2021
@aentinger
Remove superflous rtos::ThisThread::yield() from main thread 'loop()'
8d5be3b 
See #45.
@aentinger aentinger mentioned this pull request Nov 5, 2021
Merged
aentinger added a commit that referenced this pull request Nov 5, 2021
@aentinger
Remove superflous rtos::ThisThread::yield() from main thread 'loop()' (…
a1cc560 
…#48)

See #45.
@aentinger aentinger mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aentinger aentinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger